pmndrs / valtio

🧙 Valtio makes proxy-state simple for React and Vanilla
https://valtio.dev
MIT License
8.84k stars 248 forks source link

Docs site favicon is not updated #659

Closed thara003 closed 1 year ago

thara003 commented 1 year ago

Summary

I think the favicon of valtio's doc site has not been updated, it still shows up the one in the starter template of Next.js (i.e. vercel's favicon)

Link to reproduction

  1. Visit valtio.pmnd.rs/
  2. Check the favicon of the site.

Check List

Please do not ask questions in issues.

Please include a minimal reproduction.

dai-shi commented 1 year ago

But, we don't have any logos.

@roguesherlock what do you think?

roguesherlock commented 1 year ago

@dai-shi My bad. I was supposed to ask you about those and then change it but completely forgot about it. How about the 💊 symbol as favicon or should we make a new one? If we want a new one, we can ask the community or maybe I can take a stab at it. let me know what you think

dai-shi commented 1 year ago

For now, we can put 💊 . (tbh, I don't know what it is.)

roguesherlock commented 1 year ago

@dai-shi I also created a basic favicon. let me know which you like best and I'll update it, android-chrome-512x512 mstile-150x150

dai-shi commented 1 year ago

we may replace it in the future, but let's go with the first one, yours.