search

pmndrs / valtio

🧙 Valtio makes proxy-state simple for React and Vanilla
https://valtio.dev
MIT License
8.84k stars 248 forks source link

docs: fix links url #691

Closed devagja closed 1 year ago

devagja commented 1 year ago

https://github.com/pmndrs/valtio/issues/689

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fc183d28c71acf94950a192e2d3fc83466daab91:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
valtio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 3:01PM (UTC)
dai-shi commented 1 year ago

Hmm, adding extension broke the website. @roguesherlock Is it possible to remove .mdx extension when deploying website?

roguesherlock commented 1 year ago

@dai-shi Currently the renderer we use to parse the markdown doesn't support it but It should be possible to add a plugin to do that for us.

dai-shi commented 1 year ago

@dai-shi Currently the renderer we use to parse the markdown doesn't support it but It should be possible to add a plugin to do that for us.

Oh, that's unfortunate. I wonder if anyone would be interested in supporting it. Otherwise, we would need to remove the extension for now...

devagja commented 1 year ago

I am going to change the routes as at the beginning. I can research how to fix it but if anyone else can investigate, I'd appreciate it.

I leave here the link with the commit of the relative paths with mdx -> https://github.com/devagja/valtio/commit/0b6323f0e6c66fe35eb90cb1750d85683be9f39b

dai-shi commented 1 year ago

I am going to change the routes as at the beginning.

If it's about a workaround, can it be relative paths without .mdx? It won't fix, but people can add the extension when 404.

devagja commented 1 year ago

If it's about a workaround, can it be relative paths without .mdx? It won't fix, but people can add the extension when 404.

sorry for the lapse of time, I just added the relative paths without the .mdx