Closed dai-shi closed 10 months ago
The latest updates on your projects. Learn more about Vercel for Git âī¸
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
valtio | â Ready (Inspect) | Visit Preview | đŦ Add feedback | Nov 5, 2023 9:51am |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit e4c83240398f59a5ad435cc3bc650c575040df22:
Sandbox | Source |
---|---|
React | Configuration |
React TypeScript | Configuration |
React Browserify | Configuration |
React Snowpack | Configuration |
React Parcel | Configuration |
Size Change: +163 B (0%)
Total Size: 51.4 kB
Filename | Size | Change | |
---|---|---|---|
dist/esm/react/utils.js |
258 B | +33 B (+15%) | â ī¸ |
dist/react/utils.js |
277 B | +33 B (+14%) | â ī¸ |
dist/system/react/utils.development.js |
356 B | +35 B (+11%) | â ī¸ |
dist/system/react/utils.production.js |
237 B | +14 B (+6%) | đ |
dist/umd/react/utils.development.js |
433 B | +33 B (+8%) | đ |
dist/umd/react/utils.production.js |
314 B | +15 B (+5%) | đ |
I think this change is probably reasonable, because useProxy only takes care of top level property access.
Related Issues or Discussions
Fixes https://github.com/pmndrs/valtio/discussions/808#discussioncomment-7476506
Summary
Touch a dummy prop so that it avoids re-renders if no other props are touched. I'm not sure if we should add this hack, or just add a caveat note in docs.
Check List
yarn run prettier
for formatting code and docs