search

pmndrs / valtio

💊 Valtio makes proxy-state simple for React and Vanilla
http://valtio.pmnd.rs
MIT License
8.67k stars 241 forks source link

refactor!: deprecate proxyWithHistory #839

Closed lwhiteley closed 6 months ago

lwhiteley commented 6 months ago

Related Issues or Discussions

Summary

Move proxyWithHistory to the valtio-history package This includes an api change for the utility function.

The proxyWithHistory utility within valtio/utils is now marked as deprecated.

BREAKING CHANGE: see valtio-history for change notes and migration guide

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 2:01am
codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9f734dea7f06147f65bbf52d2de0ae33ff52fe7:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
dai-shi commented 6 months ago

How about adding console warning to force migrating?

https://github.com/pmndrs/valtio/blob/58f17ba0113a0dd080f69e6ac1f323cd0ba5886a/src/vanilla/utils/proxyWithComputed.ts#L23-L27

lwhiteley commented 6 months ago

updated