feat!: move to ESM first with dual ESM/CJS subpackage exports

userquin commented 3 months ago

Related Issues or Discussions

Talk with Kato and Moha in discord.

Summary

Move to ESM first and include subpackage exports.

This PR also includes:

now using rollup-plugin-dts instead typescript to generate dts files
remove useProxy from src/macro.ts module and patch the d.ts and d.cts files
change build to run build:all: now we can generate multiples outputs (d.mts, d.cts and d.ts) and also the ts3.4 version, we need to play with the target and maybe lib to fix ts3.4
ts3.4 now inside dist folder: we should include only dist in files (package.json)
postbuildnow includes only yarn copy, I've left old xpostbuild, we should remove it later
copy script now copy src and esm from root, I've left old xcopy, we should remove it later: why copying src folder to remove it in the next script?

Check List

[x] yarn run prettier for formatting code and docs

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
valtio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 7, 2024 9:07pm

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi commented 3 months ago

I can send another pr using commonjs to v2 branch (this PR should be closed)

Sounds good. This PR introduces too many changes and can't even see if there are breaking changes or not. I'm pretty sure it breaks some old environments.

I would appreciate if you can send small PRs. For example: #882 (well, it's exceptionally small.)

dai-shi commented 3 months ago

small PRs

At least, we should separate for different issues: a) fix the result in dist and b) fix for tests, which may depend on a).

pmndrs / valtio