chore: add react compiler eslint rules

pmndrs / valtio

💊 Valtio makes proxy-state simple for React and Vanilla

http://valtio.pmnd.rs

MIT License

8.66k stars 241 forks source link

chore: add react compiler eslint rules #908

Closed L-Qun closed 2 weeks ago

L-Qun commented 1 month ago

Summary

If we want better support for the React Compiler, adding eslint-plugin-react-compiler might be a good choice, I think.

Check List

[x] yarn run prettier for formatting code and docs

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
valtio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2024 2:06pm

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

pkg-pr-new[bot] commented 2 weeks ago

Run & review this pull request in StackBlitz Codeflow.

commit: 479416a

valtio

``` npm i https://pkg.pr.new/valtio@908 ```

templates

- [default](https://pkg.pr.new/template/8a4ebd91-fbbe-4cfd-8242-6f715c768940)

dai-shi commented 2 weeks ago

Thanks for the suggestion. Can you open PRs to zustand and jotai too? We try to keep the same eslint config among the three.

L-Qun commented 2 weeks ago

Thanks for the suggestion. Can you open PRs to zustand and jotai too? We try to keep the same eslint config among the three.

@dai-shi Done

valtio: https://github.com/pmndrs/valtio/pull/908
zustand: https://github.com/pmndrs/zustand/pull/2612
jotai: https://github.com/pmndrs/jotai/pull/2629

L-Qun commented 2 weeks ago

Thanks for the suggestion. Can you open PRs to zustand and jotai too? We try to keep the same eslint config among the three.

@dai-shi Done

valtio: chore: add react compiler eslint rules #908

zustand: chore: add react compiler eslint rules zustand#2612

jotai: chore: add react compiler eslint rules jotai#2629

@dai-shi 😊 Please let me know if there is anything else I need to do