Emit correct types for emscripten enums in class namespaces

isaac-mason commented 1 year ago

regnaio commented 3 months ago

@isaac-mason Thank you for all of your work on this repo

Nowadays, is it possible in TypeScript to do Module.Enum.MemberName instead of just Module.Enum?

isaac-mason commented 2 months ago

Hey @regnaio, this isn't related no, this tool generates types that match the output of the emscripten webidl binder.

This issue is for emitting correct types for enums under namespaces, e.g. Module.Namespace.MemberName, following current webidl binder behaviour.

For enums to be accessible via Module.Enum.MemberName changes to the webidl binder would be required.

There's a somewhat related issue on the emscripten repo for prefixing enums here: https://github.com/emscripten-core/emscripten/issues/13243

You could comment on that issue or raise another on the emscripten repo if you'd like.

That said, if you'd like to see it happen, you'll probably need to contribute the change yourself :)

If you were to do this and still wanted to use webidl-dts-gen to generate types, you'd need to add types for those enums yourself.

regnaio commented 2 months ago

Thank you so much, @isaac-mason , for your links and pointers helping me in the right direction

I feel like you read my mind. Indeed, I was using pmndrs/webidl-dts-gen to generate types for fabmax/physx-js-webidl 😄

isaac-mason commented 2 months ago

No worries @regnaio! 🙂

pmndrs / webidl-dts-gen