search

pmndrs / xr

🤳 VR/AR for react-three-fiber
https://pmndrs.github.io/xr/docs/
Other
2.17k stars 155 forks source link

fix(examples): fix codesandbox build #293

Closed saitonakamura closed 1 year ago

saitonakamura commented 1 year ago

Hey, @CodyJasonBennett , I saw that you've brought back path resolve in examples/vite.config.ts. I removed it on purpose so the codesandbox CI would work (it used to, but now it doesn't, not sure why). My idea is that examples are supposed to be run from the root with yarn dev, not from examples folder, and I highlighted it in https://github.com/pmndrs/react-xr/blob/master/CONTRIBUTING.md#run-locally for the newcomers. I apologize for not being clear enough in my PRs.

So, like, root vite.config will be responsible for local runs and examples/vite.config will be for codesandbox CI.

Example of codesandbox not working may be found in this PR, for instance https://github.com/pmndrs/react-xr/pull/294 https://codesandbox.io/p/sandbox/examples-j88rj5

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c52cb977b19740ef2b1e15eb1d3ce1933d67be81:

Sandbox Source
examples Configuration
saitonakamura commented 1 year ago

Hey @CodyJasonBennett , are you ok with this ^ ?