search

pmneila / PyMaxflow

Python library for creating flow networks and computing the maxflow/mincut (aka graph-cuts for Python)
http://pmneila.github.io/PyMaxflow/
242 stars 59 forks source link

add to conda-forge #53

Closed martibosch closed 3 years ago

martibosch commented 3 years ago

Hello,

I am trying to add the detectree library (which uses PyMaxflow) to conda-forge, however that requires PyMaxflow to also be in conda-forge. It should be very easy to do so (e.g., using grayskull as in grayskull pypi PyMaxflow).

I am happy to help if that interests you - it is actually quite easy. Let me know what you think. Best, Martí

martibosch commented 3 years ago

I have submitted a PR with a conda recipe so that the package can be installed from conda-forge.

pmneila commented 3 years ago

Hi, @martibosch,

That's great, thank you for your work!

Just a minor comment: the core of PyMaxflow is licensed under the GPL 3, so I think PyMaxflow should also use GPL 3, not the GPL 1. Could you please update the license file accordingly?

martibosch commented 3 years ago

Hello @pmneila,

I have amended the commit by changing GPL 1 for GPL 3.

Let me know if any further amendments are required. Best, Martí

martibosch commented 3 years ago

closing as the PR has been merged.