search

pmodels / armci-mpi

An implementation of ARMCI using MPI one-sided communication (RMA)
https://wiki.mpich.org/armci-mpi/index.php/Main_Page
Other
13 stars 7 forks source link

Use blocking put (local completion) for NbPutValue #25

Closed minsii closed 5 years ago

minsii commented 5 years ago

NbPutValue cannot be really nonblocking because the same origin addr may be used in the next NbPutValue operation before the former locally completes.

jeffhammond commented 5 years ago

These functions are never used as far as I can tell, and certainly no one has tried with this implementation because clearly the code is wrong. I think these functions were added to ARMCI for some paper years ago and left to rot.

Anyways the proposed fix is fine with me. It’s not nonblocking but at least it isn’t going to lead to a read of data that might no longer exist.