search

pmodels / armci-mpi

An implementation of ARMCI using MPI one-sided communication (RMA)
https://wiki.mpich.org/armci-mpi/index.php/Main_Page
Other
13 stars 7 forks source link

Fix the dst addrs in Get inside overlap benchmark #39

Closed MamziB closed 2 years ago

MamziB commented 2 years ago

Fix the dst addrs in Get inside contrib/non-blocking/overlap benchmark.

Signed-off-by: Mamzi Bayatpour mbayatpour@nvidia.com

@jeffhammond During our OSC UCX testings we encountered an issue with this test. Please take a look.

jeffhammond commented 2 years ago

the problem here is that the tests in contrib are from the Global Arrays repo and they are supposed to verify compliance with the official implementation. if there is a violation of the MPI standard in these tests, then it's up to ARMCI-MPI to deal with it. i'll try to solve this.

jeffhammond commented 2 years ago

ok i think this is probably a mistake in the upstream test. i'll see if i can get that fixed.

jeffhammond commented 2 years ago

see https://github.com/GlobalArrays/ga/issues/261

jeffhammond commented 2 years ago

once https://github.com/GlobalArrays/ga/pull/264 is merged, i'll copy the fix here.

jeffhammond commented 2 years ago

https://github.com/GlobalArrays/ga/pull/264 was merged