search

pmodels / armci-mpi

An implementation of ARMCI using MPI one-sided communication (RMA)
https://wiki.mpich.org/armci-mpi/index.php/Main_Page
Other
13 stars 6 forks source link

Fix tests #47

Closed sthibaul closed 6 months ago

sthibaul commented 6 months ago

The test_mpi_indexed_gets test is currently failing spuriously in debian unstable due to an uninitialized value, e.g. https://ci.debian.net/packages/a/armci-mpi/testing/amd64/44486187/ , preventing the newer mpich version from migrating to unstable.

jeffhammond commented 6 months ago

all the fabs look good. initializing the buffer is also good, although i haven't thought about whether it should be initialized to zero instead. i do not understand the XDIM change.

jeffhammond commented 6 months ago

the contribution is very much appreciated, of course.

sthibaul commented 6 months ago

The initialize needs to be 1.0+rank, the second and third loop nests actually check that (to check that MPI_Get properly intermixes values reception, not overwriting everything). I have improved the log message to mention that.

jeffhammond commented 6 months ago

i recall i had to do a release for debian long ago, or something like that, because they don't just pull from git HEAD. do i need to do that again?

sthibaul commented 6 months ago

Debian can cherry-pick fixes when they are committed upstream

sthibaul commented 6 months ago

(I plan to do it actually)

jeffhammond commented 6 months ago

ok, cool. i think it's good now but please let me know if you need anything else.