Fwd: [mpich2-dev] Null MPE log routines

[mpichbot]

Originally by "Lisandro Dalcin" dalcinl@gmail.com on 2009-05-22 15:17:57 -0500

---

----- "Lisandro Dalcin" <dalcinl@gmail.com> wrote:

> Here you have a tentative patch... Please note that the ONLY thing
> that is important for me are the return statements. If you feel that
> these "if (pointer) *pointer=value" are a nonsense, remove these
> lines
> (or ask me to provide a new patch).
>
> Regards,
>
>
> On Fri, May 22, 2009 at 2:00 PM,  <chan@mcs.anl.gov> wrote:
> >
> > The idea of mpe_log_null.c is to disable the MPE calls in MPI
> > program.  So whatever the returned arguments in the MPE should
> > probably be irrelevant.  Send me the full patch, I will see if
> > it makes sense as a whole and will try to integrate it to MPE.
> >
> > Thanks,
> > A.Chan
> >
> > ----- "Lisandro Dalcin" <dalcinl@gmail.com> wrote:
> >
> >> Looking at mpe_log_null.c, IMHO some calls are not implemented the
> >> right way... Below what I believe it should be doing:
> >>
> >> int MPE_Initialized_logging( void )
> >> { return 1; }
> >>
> >> int MPE_Log_get_solo_eventID( int *eventdef_eventID )
> >> { eventdef_eventID = -99999; return MPE_LOG_OK; }
> >>
> >> int MPE_Log_get_state_eventIDs( int *statedef_startID, int
> >> *statedef_finalID )
> >> { *statedef_startID # *statedef_finalID-99999; return
> MPE_LOG_OK;
> >> }
> >>
> >>
> >> BTW, MPE_Initialized_logging() could be improved to also return 0,
> 1,
> >> or 2 depending on the calls to MPI_Init_log() and
> MPI_Finish_log().
> >>
> >>
> >> Would you accept a full patch for this?
> >>
> >>
> >> --
> >> Lisandro Dalcín
> >> ---------------
> >> Centro Internacional de Métodos Computacionales en Ingeniería
> (CIMEC)
> >> Instituto de Desarrollo Tecnológico para la Industria Química
> (INTEC)
> >> Consejo Nacional de Investigaciones Científicas y Técnicas
> (CONICET)
> >> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> >> Tel/Fax: +54-(0)342-451.1594
> >
>
>
>
> --
> Lisandro Dalcín
> ---------------
> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> Tel/Fax: +54-(0)342-451.1594

[mpichbot]

Originally by Anthony Chan on 2009-05-22 15:17:57 -0500

---

This message has 1 attachment(s)

[mpichbot]

Originally by Anthony Chan on 2009-05-22 15:17:57 -0500

---

Attachment added: mpe_log_null.diff (1.6 KiB) Added by email2trac

[mpichbot]

Originally by chan on 2009-07-13 02:59:10 -0500

---

fixed by [0fde81441361b7095d6e9a924a971af936a2de25].