search

pmodels / oshmpi

OpenSHMEM Implementation on MPI
https://pmodels.github.io/oshmpi-www/
Other
25 stars 14 forks source link

Implementing OpenSHMEM 1.5 Team Management #108

Closed yfguo closed 3 years ago

yfguo commented 3 years ago

This PR first adds a skeleton API for team management. Then the implementation.

yfguo commented 3 years ago

I noticed the standard only says shmem_team_destroy has undefined behavior on SHMEM_TEAM_WORLD and SHMEM_TEAM_INVALID. Does this mean it should work normally with SHMEM_TEAM_SHARED? Allowing explicit freeing of a built-in team handle seems odd.

Currently, both SHMEM_TEAM_WORLD and SHMEM_TEAM_SHARED are created at init time.

yfguo commented 3 years ago

@minsii The PR is ready for review

minsii commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

minsii commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

@minsii The team test is designed to use 5 processes. Is there a way to set it?

minsii commented 3 years ago

@yfguo The test framework does not support np setting per test. I think a simple fix might be to always run mpiexec -np 5 in our jenkins job script. You can change it here : https://github.com/pmodels/oshmpi-jenkins-scripts/blob/071ee5161223fd768bfe1cf4b8deadc6eb013f21/test-oshmpi.sh#L216

But the test itself needs to return success when np is not equal to 5.

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

yfguo commented 3 years ago

test:oshmpi/mpich/sos test:oshmpi/mpich/builtin test:oshmpi/ompi/sos test:oshmpi/ompi/builtin

dalcinl commented 3 years ago

@yfguo I believe you forgot to add the SHMEM_TEAM_NUM_CONTEXTS constant.