pmodels / oshmpi

OpenSHMEM Implementation on MPI
https://pmodels.github.io/oshmpi-www/
Other
25 stars 14 forks source link

Add whitespace checker #121

Closed hzhou closed 3 years ago

hzhou commented 3 years ago

Add maint/hooks/whitespace_checker to be used as pre-commit hooks and used for CI whitespace testing.

Setting up tests whitespace and warnings. Both should automatically as well as manually triggered via PR comments.

Fixes #113

hzhou commented 3 years ago

test:oshmpi/whitespace

hzhou commented 3 years ago

It's working:

+ git rebase --verbose --exec maint/hooks/whitespace_checker pmodels/main
Changes from edc60f3c383d9db2659681784444d3d335fbe2b3 to edc60f3c383d9db2659681784444d3d335fbe2b3:
Previous HEAD position was 2e20165 Temp commit to test whitespace checker
HEAD is now at 7010da7 maint: add maint/hooks/whitespace_checker
Rebasing (2/4)
Executing: maint/hooks/whitespace_checker
Rebasing (3/4)
Rebasing (4/4)
Executing: maint/hooks/whitespace_checker
diff --git a/src/internal/coll_impl.c b/tmp/jenkins/oshmpi-tmp-52377
index ca49dfb..2a6e3ec 100644
--- a/src/internal/coll_impl.c
+++ b/tmp/jenkins/oshmpi-tmp-52377
@@ -12,7 +12,7 @@ void OSHMPI_coll_initialize(void)
     OSHMPI_coll_comm_cache.nobjs = 0;
     OSHMPI_coll_comm_cache.head = NULL;
     OSHMPI_THREAD_INIT_CS(&OSHMPI_coll_comm_cache.cs);
-    int test_white_space = 1;
+     int   test_white_space = 1;   

     /* FIXME: do we need preallocated cache pool allocated by the main
== CODE CLEANUP SCRIPT FAILED ==
warning: execution failed: maint/hooks/whitespace_checker
You can fix the problem, and then run

  git rebase --continue

Build step 'Execute shell' marked build as failure
Started calculate disk usage of build
Finished Calculation of disk usage of build in 0 seconds
Started calculate disk usage of workspace
Finished Calculation of disk usage of workspace in 0 seconds
Setting status of 2e2016510f7e549b87d5db8a1377f849c4b80a32 to FAILURE with url https://jenkins-pmrs.cels.anl.gov/job/oshmpi-whitespace-checker/2/ and message: 'Build finished. '
Using context: whitespace-checker
Finished: FAILURE
hzhou commented 3 years ago

test:oshmpi/whitespace

hzhou commented 3 years ago

test:oshmpi/warnings

hzhou commented 3 years ago

test:oshmpi/warnings

hzhou commented 3 years ago

test:oshmpi/warnings

hzhou commented 3 years ago

test:oshmpi/warnings

It is also working now. 1 warning triggered by clang:

In directory: /var/lib/jenkins-slave/workspace/oshmpi-review-warnings/compiler/clang/label/centos64
  CC       src/internal/util/gpu/fallback.lo
src/internal/util/dlmalloc.c:1278:19: warning: redefinition of typedef 'mspace' is a C11 feature [-Wtypedef-redefinition]
    typedef void *mspace;
                  ^
./src/internal/util/dlmalloc.h:528:19: note: previous definition is here
    typedef void *mspace;
                  ^
  CC       src/shmem/coll.lo
1 warning generated.
minsii commented 3 years ago

Thanks @hzhou ! They are very helpful. I will look into the clang warning in a separate fix.