search

pmonks / tools-licenses

A Clojure tools.build task library related to dependency licenses.
Apache License 2.0
6 stars 4 forks source link

:new: Add missing licenses #18

Closed jellelicht closed 2 years ago

jellelicht commented 2 years ago

Summary of changes:

Incidentally, what can I do to get this fixed upstream? I assume some kind of licensing information is missing, which is why we need the fallback in the first place.

Head's up @pmonks!

pmonks commented 2 years ago

Hey awesome - I'll take a closer look either later tonight or first thing tomorrow.

As for upstream steps, the first thing is to validate that these artifacts are indeed missing license information; it's plausible that tools-licenses isn't looking for all of the possible license files in the artifacts it scans.

I usually do this with an unzip -l <jarfile> command, then extract and open anything that looks like it might be a license file.

Once you've confirmed that these artifacts do not contain license files, I'd suggest raising an issue with the upstream project, asking them to start including one (or more) as part of their packaging process. A LICENSE file included in the root of the JAR file is reasonably standard, though that's not the only place that tools-licenses looks (they may wish to namespace it in a subdirectory to avoid clutter, for example).