search

pmontano / jsmpp

Automatically exported from code.google.com/p/jsmpp
0 stars 0 forks source link

Request to change the deliverSmResp(int) of org.jsmpp.util.DefaultComposer class to deliverSmResp(int, String) to take msgId value also #69

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. I want to create a DeliverSMResp pdu using DefaultComposer class
2. As per SMPP spec we need to provide the msgId value also in the body of
the DeliverSMResp pdu.
3. In the deliverSmResp(int sequenceNumber) method of the DefaultComposer
class the msgID is set to null automatically.

What is the expected output? What do you see instead?
I expect the msgID to be set to null only if I specify the second argument
to be null in the method signature I suggest. Else the programmer will have
to again append byte after 16th postion in the byte[] already composed.

What version of the product are you using? On what operating system?
I am using jsmpp version 2.0.1. My operating system is ubuntu 8.04.

Please provide any additional information below.
The other methods in the DefaultComposer class are satisfactory. A slight
change for this method would be nice to use the library in a more
convenient way.

Original issue reported on code.google.com by hbkricha...@gmail.com on 15 Apr 2010 at 7:38