search

pmoreno-rodriguez / grav-theme-editorial

Editorial is a GravCMS port of the Editorial theme from HTML5Up.net.
Other
13 stars 2 forks source link

Suggestion: remove unnecessary spacing #27

Closed Fazarel closed 10 months ago

Fazarel commented 10 months ago

/templates/blog.html.twig /templates/item.html.twig

In order to remove space above title, when not using breadcrumbs

Changes from:

    <p>
    {% if show_breadcrumbs and config.plugins.breadcrumbs.enabled %}
        {% include 'partials/breadcrumbs.html.twig' %}
    {% endif %}
    </p>

To:

    {% if show_breadcrumbs and config.plugins.breadcrumbs.enabled %}
    <p>
        {% include 'partials/breadcrumbs.html.twig' %}
    </p>
    {% endif %}
pmoreno-rodriguez commented 10 months ago

@Fazarel,I just applied your suggestion. In the next version of the theme it should already be applied.

Fazarel commented 10 months ago

After thinking about it, I think it would be better to simply delete the <p> and </p> that frame the breadcrumbs code snippet. This changes the spacing relative to the title in a different way between pages that have breadcrumbs enabled and those that don't. The theme loses homogeneity.

pmoreno-rodriguez commented 10 months ago

Fixed in version 2.0.0