search

pmoreno-rodriguez / grav-theme-editorial

Editorial is a GravCMS port of the Editorial theme from HTML5Up.net.
Other
13 stars 2 forks source link

Fazarel patch 1 #33

Closed Fazarel closed 10 months ago

pmoreno-rodriguez commented 10 months ago

Is this PR a substitute of https://github.com/pmoreno-rodriguez/grav-theme-editorial/pull/30

If so, could you close that PR?

Fazarel commented 10 months ago

Is this PR a substitute of #30

Yes.

If so, could you close that PR?

I'm not familiar with github and git. Is it ok now?

pmoreno-rodriguez commented 10 months ago

Yes, thanks. I'm also not very familiar with github, so I make changes with caution. Please be patient these days. I have a lot of work personally until almost the end of the month, but I will incorporate all the changes as soon as possible.

pmoreno-rodriguez commented 10 months ago

Hi again. I have assigned these changes to you if that is okay with you. In the translation of the Menu section you added (thanks for this correction), we should put "sidebar" instead of "top", since the theme does not have a top menu.

This is a small copy and paste glitch from the Future2021 theme. Could you make those changes in all three languages and re-upload this Pull Request?

Thank you so much.