search

pmoreno-rodriguez / grav-theme-editorial

Editorial is a GravCMS port of the Editorial theme from HTML5Up.net.
Other
13 stars 2 forks source link

Why don't you use custom.css? #35

Closed Fazarel closed 10 months ago

Fazarel commented 10 months ago

To apply a few modifications quickly and easily, why not allow custom.css to be used? As suggested in the documentation: https://learn.getgrav.org/17/themes/customization

Especially since the file exists /assets/css/custom.css and the comment in the first line invites you to use it...

For marginal modifications, it would be simpler than recompiling with SASS or modifying /assets/css/misc.css, which forces you to copy the entire content and loses the advantage of theme inheritance.

I suggest adding just one line to /templates/partials/base.html.twig {% do assets.addCss('theme://assets/css/custom.css', {'priority': 5}) %}

pmoreno-rodriguez commented 10 months ago

I'm doing a deep review of the theme, improving some coding aspects and correcting some bugs (thanks to suggestions like yours), but at the moment I won't be able to make any more changes until the end of September since I'm on vacation.

Fazarel commented 10 months ago

Don't worry, I've understood that you're not immediately available. I just keep bumping up bugs and suggestions when I have time and before I forget, so they are tracked and you accept them or not when you have the time.

Unless that bothers you?

Thanks again... and happy vacations!

pmoreno-rodriguez commented 10 months ago

Fixed in version 2.0.0