pmoreno-rodriguez / grav-theme-mundana

Mundana Jekyll theme ported to Grav
MIT License
7 stars 2 forks source link

sc-alert classes wrong colors #16

Open fugo opened 3 months ago

fugo commented 3 months ago

I found some wrong colors in the sc-alert css codes.
the class .alert-white is bad and .alert-primary is the same as .alert-success.

Here is an excerpt from the theme.css file and my suggestions:

.alert-primary {
    color:#fff;
    background-color:#28a745;   /* same as success – better #2943E6   */
    border-color:#28a745;       /* same as success – better #2943E6   */
}
.alert-primary hr {
    border-top-color:#038f6a;   /* same as success – better #5367e0   */
}

.alert-success {
    color:#fff;
    background-color:#28a745;
    border-color:#28a745;
}

.alert-white {
    color:#fff;                /* white on white - better #000 */
    background-color:white;
    border-color:white;
}
.alert-white hr {
    border-top-color:#f2f2f2;
}
.alert-white .alert-link {
    color:#e6e6e6;              /* better #333 */
}

.alert-lightblue {
    color:#fff;                 /* white too bright - better #000 */
    background-color:#e8f3ec;   /* better #adc8e6 */
    border-color:#e8f3ec;       /* better #adc8e6 */
}
.alert-lightblue hr {
    border-top-color:#d7eade;   /* better #7d93ad */
}
.alert-lightblue .alert-link {
    color:#e6e6e6;              /* better #333 */
}   

btw your /assets/css/ has a file custom.css, when you update the theme the existing custom.css will be overwriten with the new empty file.
Better to use a name like custom.css.example .
Yes – I know, always backup before update :smile:

I use the latest version of Mundana.
Thank you for this nice and usefull theme.

pmoreno-rodriguez commented 3 months ago

Hi @fugo ~~I fixed it with the latest version 1.3.1 Have you tried with that version?~~

I'll take a look later.

QThe styles in theme.css are the original ones from the Mundana theme for Jekyll. I'm thinking of leaving Bootstrap colors alone

pmoreno-rodriguez commented 3 months ago

btw your /assets/css/ has a file custom.css, when you update the theme the existing custom.css will be overwriten with the new empty file. Better to use a name like custom.css.example

If you want to avoid losing changes with each update, you will need to create a child theme, and copy your modified files into the folders of that child theme. You can follow the steps in the Grav documentation.