pmoreno-rodriguez / grav-theme-telephasic

Telephasic theme by HTML5Up ported to Grav
Other
4 stars 2 forks source link

Social icons are partially reset on cache clear #13

Closed tlkelley closed 8 months ago

tlkelley commented 10 months ago

In the theme settings:

image

If you have fewer than 6 social icons, when the cache is cleared, the remaining ones from user/themes/telephasic/telephasic.yaml will repopulate.

For example: Currently, I have 3 social icons saved:

image

If I go to the admin dashboard and clear the cache, this is what I return to in the theme settings:

image

user/config/themes/telephasic.yaml contains the saved icons:

image

Contents of user/themes/telephasic/telephasic.yaml:

image

Theme config in admin panel shows effectively a merge of the two, where the first three are the ones that were saved, and the second three are the "missing" ones from the theme's base file.

image

If I remove the last three from the theme's base file, this problem goes away. Changing user/themes/telephasic/telephasic.yaml to:

image

makes it so my saved social icons persist through cache clearing.

pmoreno-rodriguez commented 10 months ago

Thanks for your contribution. I'll try to fix this soon

pmoreno-rodriguez commented 8 months ago

Hi @tlkelley . Can you confirm if this issue is solved with the latest version of theme?

tlkelley commented 8 months ago

@pmoreno-rodriguez looking great! I'd say that's fixed!

tlkelley commented 8 months ago

Fixed in 1.0.6