search

pmorie / osb-broker-lib

A go library for developing an Open Service Broker
Apache License 2.0
28 stars 23 forks source link

For OpenAPI, enable CORS. #17

Closed n3wscott closed 6 years ago

n3wscott commented 6 years ago

I wanted to test my new fancy broker with the swagger UI but CORS was not enabled and no way to do it. So I added it.

jmrodri commented 6 years ago

What prompted the rename of util.go to writer.go? I only ask because it doesn't seem as generic as a normal writer. Otherwise, the changes seem sane and useful.

jmrodri commented 6 years ago

I see what you did, they are now part of the APISurface struct. I'd prefer that if we're making them part of the APISurface they should just be in the apisurface.go.

n3wscott commented 6 years ago

@jmrodri take another look, thanks!

jmrodri commented 6 years ago

@n3wscott I like that. :+1:

jmrodri commented 6 years ago

LGTM

carolynvs commented 6 years ago

LGTM