search

pmorie / osb-broker-lib

A go library for developing an Open Service Broker
Apache License 2.0
28 stars 23 forks source link

osb.ProvisionResponse Incorrect json key for operation token/key #22

Closed shawn-hurley closed 6 years ago

shawn-hurley commented 6 years ago

Currently broker.Interface/business logic uses the https://github.com/pmorie/go-open-service-broker-client/blob/master/v2/types.go#L192 type. This has the json for the operation as operationKey. According to the spec it should be operation.

It appears there is an internal unexported structure: https://github.com/pmorie/go-open-service-broker-client/blob/e8aa16c9036317bd59ced8921e9da6197ab577e3/v2/provision_instance.go#L21 that has the correct json keys.

pmorie commented 6 years ago

Sounds like: https://github.com/pmorie/go-open-service-broker-client/issues/91

Go ahead and change the json tag in the client and I'll do a release of the client so we can fix this.

jmrodri commented 6 years ago

@pmorie I think this is done since the PR was merged already.