search

pmorie / osb-broker-lib

A go library for developing an Open Service Broker
Apache License 2.0
28 stars 23 forks source link

adding library response types #27

Closed shawn-hurley closed 6 years ago

shawn-hurley commented 6 years ago

This is in regards to #13.

This creates the new types of the responses that the broker.Interface will eventually use.

cc @pmorie @jmrodri

jmrodri commented 6 years ago

LGTM, matches what was discussed in that issue.

pmorie commented 6 years ago

LGTM

jmrodri commented 6 years ago

LGTM

jmrodri commented 6 years ago

Is this waiting for anything? Can one of you merge? @pmorie @carolynvs @LiliC

carolynvs commented 6 years ago

LGTM 3 - merging

lilic commented 6 years ago

I would really like to have some kind of a "breaking change" in a description, or a label in the PR. So we can easily add to the release notes, and then when we bump versions in our brokers or in the osb-starter-pack we know what to look out for. :) WDYT? @carolynvs @pmorie @shawn-hurley

shawn-hurley commented 6 years ago

I think that would be useful for all downstream users of the library. I think that it should probably be on the PR in my opinion.

carolynvs commented 6 years ago

Agreed! We would all use the hint and the best place for it is in the PR title or main comment.