search

pmorie / osb-broker-lib

A go library for developing an Open Service Broker
Apache License 2.0
28 stars 23 forks source link

apisurface: Set PlanID and ServiceID in UnbindRequest #44

Closed indradhanush closed 6 years ago

indradhanush commented 6 years ago

plan_id and service_id are available as query parameters in an unbind request according to the OSB spec: https://github.com/openservicebrokerapi/servicebroker/blob/v2.13/spec.md#parameters-3

There is a change in the function signature and usage of unpackUnbindRequest similar to that of unpackUpdateRequest to make testing easier. See commit 2445295453a69eabd43ea408124de3f1e118840c for more information.

This PR also fixes #43

indradhanush commented 6 years ago

Updated commit to add comment.

shawn-hurley commented 6 years ago

This fix is super helpful thank you

pmorie commented 6 years ago

Thanks for the fix @indradhanush - add a test and we can merge.

indradhanush commented 6 years ago

While writing the tests I found out that ServiceID was unset as well. I've fixed that in this PR and updated the title and description accordingly.

lilic commented 6 years ago

Thanks for your first contribution! (of many hopefully) 🎉

lilic commented 6 years ago

@indradhanush p.s. this is now in the 0.0.10 release https://github.com/pmorie/osb-broker-lib/releases/tag/0.0.10