pmorie / osb-broker-lib

A go library for developing an Open Service Broker
Apache License 2.0
28 stars 23 forks source link

Polling Last Operation for Service Bindings Must Has an Originating Identity #60

Open expinc opened 2 years ago

expinc commented 2 years ago

Check https://github.com/pmorie/osb-broker-lib/blob/87d71cfbf3427836e5623f1e3843a466348b7be6/pkg/rest/apisurface.go#L449 . It would fail if there is no originating identity when polling last operation for service bindings.

However, according to https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#originating-identity , originating identity is not mandatory for requests. The responsibility of how to handle originating identity should belong to the business logic of the service broker.

Check https://github.com/pmorie/osb-broker-lib/blob/87d71cfbf3427836e5623f1e3843a466348b7be6/pkg/rest/apisurface.go#L143 . This is a recommended handling of originating identity from framework's perspective: just output a log.