search

pmorie / osb-starter-pack

A quickstart for making a new Open Service Broker
Apache License 2.0
69 stars 47 forks source link

Rename user pkg to broker #70

Closed lilic closed 6 years ago

lilic commented 6 years ago

As the other pkgs were separated to its own library it makes more sense to call the user pkg broker instead. This also avoids the need for the consumer to later rename the user pkg, as the name is generic enough that it can be kept.

As agreed @pmorie this renames the user pkg to broker. Not sure broker is the best name, as there is the broker pkg in github.com/pmorie/osb-broker-lib/pkg/broker as well? WDYT?

lilic commented 6 years ago

@carolynvs 👍 So maybe we should rename the broker in the lib then? Any naming suggestions for that one? Couldn't come up with anything myself, that sounded descriptive enough.

carolynvs commented 6 years ago

@LiliC Oops! I fat fingered that comment and I'm not sure how to edit it now. I was trying to say that using the same package name is NOT a problem for me. 😊

pmorie commented 6 years ago

LGTM, thanks for the patch @LiliC

lilic commented 6 years ago

@carolynvs That makes more sense! :D