pmorie / osb-starter-pack

A quickstart for making a new Open Service Broker
Apache License 2.0
69 stars 47 forks source link

Modified Makefile's clean command to actually remove "image/servicebroker" #86

Closed SamiSousa closed 6 years ago

SamiSousa commented 6 years ago

Found an apparent bug when running the "make clean" command, where the binary stored in "image/" isn't removed on cleanup.

SamiSousa commented 6 years ago

Added the line in question, restoring the previous command.

pmorie commented 6 years ago

@SamiSousa this is a large amount of commits for the addition of a single line.

I suggest this:

$ git reset upstream/master
$ git commit -am "Make 'make clean' remove image/servicebroker"

and then re-push to this branch.

SamiSousa commented 6 years ago

Thanks Paul! Learning a git command a day keeps the merge conflicts away.