pmorie / osb-starter-pack

A quickstart for making a new Open Service Broker
Apache License 2.0
69 stars 47 forks source link

Token Review #88

Closed shawn-hurley closed 6 years ago

shawn-hurley commented 6 years ago

Adding ability to us a middleware to validate the bearer token from the service catalog.

shawn-hurley commented 6 years ago

One of the issues that I had trouble solving was how to test the token review. I would like to use the client-go mock to check but don't know how to set it for the token review middleware. Any ideas?

lilic commented 6 years ago

@shawn-hurley In case you haven't seen it, there is also this project that does something similar https://github.com/brancz/kube-rbac-proxy

shawn-hurley commented 6 years ago

@pmorie I think this should be ready for another review

pmorie commented 6 years ago

LGTM - I'm going to try to this out locally before I merge.