pmorissette / ffn

ffn - a financial function library for Python
pmorissette.github.io/ffn
MIT License
1.87k stars 282 forks source link

Ulcer index fixes / pandas 2.0 fixes #196

Closed RoryGlenn closed 1 year ago

RoryGlenn commented 1 year ago

This change resolves #193 by calculating the ulcer index according to the definition.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.46% and project coverage change: -0.13 :warning:

Comparison is base (16aefe6) 57.37% compared to head (c957457) 57.25%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #196 +/- ## ========================================== - Coverage 57.37% 57.25% -0.13% ========================================== Files 4 4 Lines 1159 1165 +6 Branches 249 249 ========================================== + Hits 665 667 +2 - Misses 430 434 +4 Partials 64 64 ``` | [Impacted Files](https://app.codecov.io/gh/pmorissette/ffn/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ffn/core.py](https://app.codecov.io/gh/pmorissette/ffn/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZmZuL2NvcmUucHk=) | `59.72% <58.97%> (-0.16%)` | :arrow_down: | | [ffn/data.py](https://app.codecov.io/gh/pmorissette/ffn/pull/196?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZmZuL2RhdGEucHk=) | `22.78% <75.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.