search

pmorissette / ffn

ffn - a financial function library for Python
pmorissette.github.io/ffn
MIT License
2.03k stars 300 forks source link

importing ffn is changing matplotlib settings #205

Closed nkonts closed 11 months ago

nkonts commented 12 months ago

Is your feature request related to a problem? Please describe. I find it highly unintuitive that importing ffn is overwriting the currently set matplotlib style by the user.

Describe the solution you'd like I would suggest to remove the try-except block in ffn/core.py following line 23:

try:
    import seaborn as sns

    sns.set(style="ticks", palette="Set2")
except ImportError:
    pass

Instead, if the user wants to change any matplotlib settings, it should be the user doing it consciously and not be influenced by the order of importing.