Replace deprecated use of .ix with .iloc

pmorissette / ffn

ffn - a financial function library for Python

pmorissette.github.io/ffn

MIT License

1.97k stars 294 forks source link

Closed johnsloper closed 6 years ago

johnsloper commented 6 years ago

Replaced all occurrences of the deprecated .ix usages where it is clear that .iloc can be used instead. .iloc should also be faster than .ix

JordanPlatts commented 6 years ago

Thanks for contributing. Can you look into the errors in Travis? I think it just some import issues. Once that is resolved I will merge the pr.

JordanPlatts commented 6 years ago

I am getting the same error now with other changes because pandas 0.23 isn't compatible with pandas-datareader(0.6.0 or 0.5.0).

I am just going to merge this fix.

johnsloper commented 6 years ago

Hi Jordan, sorry for my lack of replies. Was off work.

Thanks for merging in the changes. Happy to contribute back in whatever small way I can 👍