search

pmorissette / ffn

ffn - a financial function library for Python
pmorissette.github.io/ffn
MIT License
2.03k stars 300 forks source link

bug: plot_scatter_matrix #82

Closed simjason closed 3 years ago

simjason commented 5 years ago

In plot scatter matrix:

pd.scatter_matrix(ser, figsize=figsize, **kwargs)

needs to be:

pd.plotting.scatter_matrix(ser, figsize=figsize, **kwargs)

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.plotting.scatter_matrix.html

y26805 commented 4 years ago

duplicate of https://github.com/pmorissette/ffn/issues/76

y26805 commented 4 years ago

technically not a bug but a feature, since requirements.txt rightly specified 0.22.0 https://github.com/pmorissette/ffn/blob/ef86a714afbb6dab8fcbb897de4a4553f76e8073/requirements.txt#L4