pmotschmann / Evolve

An incremental game about evolving a civilization
Mozilla Public License 2.0
831 stars 357 forks source link

Make building queue be lines, numbered lists, or bullet lists #998

Closed StoneCypher closed 7 months ago

StoneCypher commented 10 months ago

The queue can be hard to read for some people when it's very long, and the jquery sort plugin isn't superb at inline wrapped sorting.

A while back, @elzibubble requested in #496 that the queue be displayable as rows. I decided that I agreed.

This patch creates a new option Queue style, which defaults to the current behavior, which is called "standard queue." It also introduces three new styles:

  1. List queue
  2. Bullet list queue
  3. Numbered list queue

I am aware that due to length, this control can wrap inappropriately. A fix for that is inbound in a separate PR, because it impacts more controls than just this new option.

I have done my best to imitate your style and approach, including formatting. The item is stored in config the same way as other things, and the selection is done by a class name on html, in the same fashion as themes. I continued your control style as well.

I was unable to keep the queue rules with the existing queue rules, because they are in a less inherited container on .main, and these rules hinge on a class above .main on html. I considered moving the queue rules with them, but decided that's not my choice to make, though I support it.

Strings are, I believe, appropriately i18n translated.

 

 

Standard queue appearance

image

 

 

List queue appearance

image

 

 

Bullet list queue appearance

image

 

 

Numbered list queue appearance

image

fredden commented 9 months ago

I wonder if the "No Queue Order" setting should determine if the bullets should be numbers or dots. (ie, switch between <ol> and <ul>)

StoneCypher commented 9 months ago

y'know, that's interesting

i'd be open to either:

  1. adding a fifth type, "auto bullet list," which works that way, or
  2. adding said fifth type but also removing both existing types

i would mildly prefer 1, allowing players complete control, as i want bullets when they're ordered

fredden commented 9 months ago

Does / should this change apply to the Research Queue?