Determinism fixes and full output precision

pmoulon / CMVS-PMVS

This software (CMVS) takes the output of a structure-from-motion (SfM) software as input, then decomposes the input images into a set of image clusters of managable size. An MVS software can be used to process each cluster independently and in parallel, where the union of reconstructions from all the clusters should not miss any details that can be otherwise obtained from the whole image set. CMVS should be used in conjunction with an SfM software Bundler and an MVS software PMVS2 (PMVS version 2).

http://opensourcephotogrammetry.blogspot.com/

939 stars 464 forks source link

Determinism fixes and full output precision #39

Closed nh2 closed 4 years ago

nh2 commented 4 years ago

Hey,

here's a set of fixes we carry locally that we'd like to upstream.

The key points are

determinism (following up on #36, #37, #38), in this case by using a fixed seed for shuffling
outputting accuracy as a field in the output .ply files
fixing a division by zero
enabling full output precision of floating point values being emitted (see commit message for an example)

For the last point, it fixes expected output like this:

degenerating into output like this when the object is not close to the origin:

Close-up:

nh2 commented 4 years ago

I can split up the commits into separate PRs if you don't want all of them batched, but I thought I'd first show them all in case they are desired.

nh2 commented 4 years ago

I've updated the PR to implement the feedback.

pmoulon commented 4 years ago

Thx @nh2