search

pmqs / zipdetails

zipdetails - Display details about the internal structure of Zip files.
47 stars 2 forks source link

Removal of 32 bit support break core perl i386 test t/porting/utils.t #8

Closed demerphq closed 2 years ago

demerphq commented 2 years ago

See also: https://github.com/pmqs/zipdetails/pull/7 https://github.com/Perl/perl5/pull/19618 https://github.com/pmqs/IO-Compress/issues/45 https://github.com/Perl/perl5/issues/19617

Current core fails test on 32 bit architectures with:

# Failed test 83 - utils/zipdetails compiles at porting/utils.t line 85
#      got "Integer overflow in hexadecimal number at utils/zipdetails line 1432.
Integer overflow in hexadecimal number at utils/zipdetails line 2247.
Integer overflow in hexadecimal number at utils/zipdetails line 2248.
Integer overflow in hexadecimal number at utils/zipdetails line 2249.
Integer overflow in hexadecimal number at utils/zipdetails line 2250.
Integer overflow in hexadecimal number at utils/zipdetails line 2251.
Integer overflow in hexadecimal number at utils/zipdetails line 2252.
Integer overflow in hexadecimal number at utils/zipdetails line 2253.
Integer overflow in hexadecimal number at utils/zipdetails line 2254.
utils/zipdetails syntax OK
"
# expected "utils/zipdetails syntax OK
"
t/porting/utils .................................................. FAILED at test 83

I created https://github.com/Perl/perl5/pull/19618 which detects the warning produced by this patch.

pmqs commented 2 years ago

Fixed via https://github.com/pmqs/zipdetails/pull/7 so closing