search

pmret / papermario

Decompilation of Paper Mario (2000)
https://papermar.io
1.35k stars 128 forks source link

`SHIFT_BSS` be gone #1173

Closed Alto1772 closed 8 months ago

Alto1772 commented 9 months ago
BowserSlug commented 9 months ago

🚀🚀🚀🚀🚀🚀🚀🚀 This PR matches 8 functions (+0.00%) on jp. 🚀 This PR matches 1 function (+0.00%) on ique.

Alto1772 commented 9 months ago

my main concern with this approach is the fact that making things static unfortunately makes them less visible. However, it seems like SHIFT_BSS was defined as just static in some cases anyway...hmm

Yeah good suggestion. The reason I did is to just be made as intended by the original developers. The BSS addresses located between the 2 common sections were originally meant to be static so I made it one too...

As a suggestion and my personal understanding, I'll just make the static ones visible by using BSS macro instead. (addendum: except for the libultra & nusys ones)