pmu-tech / stub-server

Stub server for REST APIs
MIT License
12 stars 2 forks source link

Fix various issues #32

Closed tkrotoff closed 2 years ago

tkrotoff commented 3 years ago
dsumac commented 3 years ago

why make a big merge request with several responsibilities ? :wink:

tkrotoff commented 3 years ago

Because of higher cost (e.g takes more time). And the added value of the extra steps is none considering there are 8 commits short and easy to understand.

8 commits spread over 4 PRs that you need to rebase.

Also it was while working on # 31 and browsing the source code that I've discovered that I could improve the types, the documentation and replace "HTTP verb" with "HTTP request method" (proper term).