search

pmuller / django-crowd-auth

Atlassian Crowd SSO integration for Django applications
Other
10 stars 6 forks source link

pip 10.x install breaks on unused parse_requirements import in setup.py #10

Closed elwinarens closed 6 years ago

elwinarens commented 6 years ago

pip 10.X+ has moved the module pip.req to pip._internal.req, which causes setup.py to fail for pip 10.X+ on this include:

from pip.req import parse_requirements

Causes the following error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File ".../django-crowd-auth/setup.py", line 4, in <module>
    from pip.req import parse_requirements
ImportError: No module named 'pip.req'

https://github.com/pmuller/django-crowd-auth/blob/master/setup.py#L4

Additionally, the parse_requirements function is not used as far as i can tell, so it seems this entire import can be removed.

pmuller commented 6 years ago

Well spotted, thanks! I merged your PR.

elwinarens commented 6 years ago

Thanks for the merge! Would you mind creating a new release that ends up in pip? So i can remove the pip github requirement.