search

pmur002 / gridgraphics

Redraw base graphics as grid graphics
33 stars 8 forks source link

Edit plotdiff() and plotcompare() to allow use of plotdiff() on Windows #1

Closed JoshOBrien closed 9 years ago

JoshOBrien commented 9 years ago

machines on which ImageMagick is installed. R's Sys.which() and system2() aren't fully portable to Windows OS, since they prepend 'PATH' with the Windows system directories, here shadowing ImageMagick's convert.exe with C:\Windows\System32\convert.exe. The solution used here is to instead use shell(), which leaves 'PATH' alone. (More details in this R-devel thread: https://stat.ethz.ch/pipermail/r-devel/2015-May/071195.html)

With the changes made here, all of the examples in demo-graphics.R run and are successfully processed. If these changes (or something like them) are incorporated, the "Note" in ?plotdiff should also be removed.

pmur002 commented 9 years ago

Thanks Josh! gridGraphics_0.1-5 includes this patch.

JoshOBrien commented 9 years ago

Great, thanks!

I probably should've mentioned that I didn't check whether my edits broke any functionality under *NIX or OSX operating systems, though I'm guessing you'll have checked that before merging the patch!

Also, just submitted another minor pull request that modifies plotdiff.Rd to reflect the changes we just made.

Thanks for all of your terrific work on R's graphical facilities.

On Sun, Jul 19, 2015 at 6:21 PM, pmur002 notifications@github.com wrote:

Thanks Josh! gridGraphics_0.1-5 includes this patch.

— Reply to this email directly or view it on GitHub https://github.com/pmur002/gridgraphics/pull/1#issuecomment-122725836.