search

pmur002 / vwline

An R package to draw variable-width lines
24 stars 3 forks source link

grid.vwXspline and friends missing argument vp = NULL ? #1

Open bryanhanson opened 7 years ago

bryanhanson commented 7 years ago

Hi Paul. Nice package, I'm putting it to use.

Not sure if this is intentional, but it looks like none of the functions that actually draw something include the argument vp = NULL. In grid all drawing functions include this argument, which of course saves some extra steps. Perhaps this applies to the *Grob functions too.

pmur002 commented 7 years ago

Hi. Great to hear that someone is using it :) I would be interested to see your final result if you are happy/able to share.

Thanks for pointing out the 'vp' issue. Pure oversight on my part. I will put it on my list to add (I don't think there are any good reasons not to).

bryanhanson commented 7 years ago

My use is not exactly technical -- I'm building a variation of the kandinsky package. I remembered reading about vwline and I'm experimenting with different variations on splines to add to the paintings -- just some on the side fun.

pmur002 commented 7 years ago

Ah! I saw that the other day. Good fun, and I can see how some more natural looking curves might help.