search

pmusaraj / discourse-mobile-single-site-app

Single-site app wrapper for a Discourse site. Supports Push Notifications via OneSignal.
MIT License
81 stars 24 forks source link

Minor: Connect buttons remains after successful connect #5

Closed nommaz closed 6 years ago

nommaz commented 7 years ago

  1. Click skip then login using discourse login button. Click connect after succesful login. Authorize comes up and notifications are allowed. When the site returns after Apple notification prompt, bottom row housing connect button should be hidden

  2. Click skip then connect before discourse login and nothing seems to happen (the page refreshes if you pay attention). It gives the impression to the user as if the button is broken, however it does do its job and once user logs in to discourse she sees the authorize page right away. It would be great if the bottom row housing the connect button could be hidden until user is authenticated with discourse.

pmusaraj commented 7 years ago

Yeah... maybe. however, the label for that button is configurable in global.js.

nommaz commented 7 years ago

You are right, just wanted to make sure I am not misinterpreting its function. By the way I updated my original comment to reflect 2 different cases

pmusaraj commented 6 years ago

This should be now fixed with the recent merge.