search

pmusolino / PMAlertController

PMAlertController is a great and customizable alert that can substitute UIAlertController
MIT License
2.53k stars 187 forks source link

Added a support of adding a UITextField to the alert controller. #27

Closed owlcoding closed 7 years ago

The0racle commented 7 years ago

+1

pmusolino commented 7 years ago

This weekend I will look at this pull request.

fedmeloni commented 7 years ago

Sorry @Codeido , what about this pull request?

pmusolino commented 7 years ago

Hi @owlcoding, thanks for this pull request and sorry for the delay.

I reviewed the pull request, and the principle around the implementation is ok, but there are some problems. For example, when i select a text field and the keyboard appear, the text field go under the keyboard. In this way, i can't close the keyboard and i can't see what i wrote on the textfield.

If you implement this part, i can merge your pull request ;)

simulator screen shot 27 dic 2016 14 00 00

pmusolino commented 7 years ago

Merged. Thanks to @klauslanza for the fix. https://github.com/Codeido/PMAlertController/pull/34

klauslanza commented 7 years ago

Thanks @Codeido and thanks to @fedmeloni for the kickstart :-)