Updated for Swift 4 support

pmusolino / PMAlertController

PMAlertController is a great and customizable alert that can substitute UIAlertController

MIT License

2.53k stars 186 forks source link

Closed JackYoustra closed 7 years ago

JackYoustra commented 7 years ago

Doesn't break existing Swift 3 support, just makes explicit @objc hints

pmusolino commented 7 years ago

Hi @JackYoustra, thanks for this PR.

I don't understand why you makes explicit @objc on methods keyboardWillShow and keyboardWillHide. You tried this on Xcode 9?

Thanks -Paolo

pmusolino commented 7 years ago

After a review, I merged your PR here, in the "swift4" branch https://github.com/Codeido/PMAlertController/pull/52

Thanks for your contribution! 🥇 -Paolo