Migrate to SPM

[ipavlidakis]

• Migrated to SPM
• Introduced WormholySwift as a wrapper target for Swift files as SPM doesn't support multi-lang modules
• Cleaned up and update demo
• Removed configs as unnecessary
• Updated podfile

Resolves #112, #139

[ipavlidakis]

@pmusolino what do you think?

[gmoraleda]

It would be great to see this merged @pmusolino 🙌 Thanks for the PR @ipavlidakis !

[dnKaratzas]

Could you please merge that?

[zdurlan]

Please merge this when possible, this will be of real help

[pmusolino]

Hey @ipavlidakis, thank you so much for your contribution! I was just wondering if you could help me understand the changes you made in this PR that aren't related to the SPM migration, such as the changes to the XIB files. Would you be able to explain the reasoning behind those changes? Thanks again!

[dnKaratzas]

@pmusolino the only diff I see is that the files moved to a different directory

[pmusolino]

@dnKaratzas ActionableTableViewCell.xib was not moved but has some changes for example.

[ipavlidakis]

@pmusolino I don't recall making changes to .xib files other than moving them to match the SPM file structure. The changes were probably made from the different version of Xcode, that's why you can see mainly changes on version fields

[dnKaratzas]

@pmusolino minor changes cause opened the xib on a different Xcode version. So those are Xcode changes. Then onlly actual change I can spot is the module name that is an accepted change: customModule="WormholySwift"

[mparmar-covantex]

Right. I agree with @dnKaratzas & @ipavlidakis as well

Can you please merge it? @pmusolino

Thank you in advance..

[mparmar-covantex]

It would be great to see this merged @pmusolino , Any updates?

[mehulparmar4ever]

Hello @pmusolino, Can you please merge this PR? cc: @ipavlidakis

Thanks.

[azdurlan-spectra]

We really need this.

[mehulparmar4ever]

@ipavlidakis @pmusolino Any updates?

[pmusolino]

@ipavlidakis could I ask you to fix the merge conflicts, so I can review this PR and merge it?

[pmusolino]

@ipavlidakis do you have time to fix the merge conflicts? It would be really helpful to offer SPM 🙌 thanks!

[ipavlidakis]

Sure, i'm on it and should have something ready in following few hours 🤞🏻

[pmusolino]

@ipavlidakis do you have any update on this? 🙏

[ipavlidakis]

Hey @pmusolino sorry for the delay. I have updated the PR and I'm going to test it tomorrow. It will be great if you can also check it and let me know your thoughts. Thanks

[pmusolino]

Thanks @ipavlidakis! Can I test it right away or should you need to apply extra changes?

[ipavlidakis]

Feel free to test it as it is.

[pmusolino]

I'll test it this weekend and early next week, thanks @ipavlidakis 🙏

[pmusolino]

@ipavlidakis I'm testing the PR.

The first issue that I noticed, is that while I try to run WormholyDemo on the simulator, I get this error: Missing package product Wormholy

Taking a look at the structure of the Xcode project, it seems that all the classes of the library, the folders, etc... are missing. I'm using Xcode 15.2.0.

Any suggestion on how to move forward?

[parmar-mehul]

Hello @ipavlidakis ,

PR: https://github.com/ipavlidakis/Wormholy/pull/3

Below line should be removed, There is no similar file. "Support Files/Assets.xcassets"

And, You can delete this two files as well, May be, That is old structure. Remove it and Build demo app, It works.

[pmusolino]

Thanks, @parmar-mehul for the collaboration 🚀 let's wait for @ipavlidakis to review and merge your PR.

[parmar-mehul]

Thanks, @parmar-mehul for the collaboration 🚀 let's wait for @ipavlidakis to review and merge your PR.

Hello @ipavlidakis, Do we have any updates? It has been a week now! Hope we will get this done soon. Thank you for your time!!

[pmusolino]

@ipavlidakis let us know when you will be able to take care of this, thanks! 🙌

[ipavlidakis]

Sorry for the wait folks but that ended up being much more complicated than it was when the PR was initially opened (that combined with limited personal time to work on it made me pick up on it late).

I tested the current changes with a project integrating the library via SPM and made sure that embedded Demo project builds. It would be great if any of you is available to do a quick check with Cocoapods & Carthage as I haven't used them in a very long time and it may take me some time to set them up.

@pmusolino let me know your thoughts.

[pmusolino]

Thank you @ipavlidakis for finding the time!

I did a test with Cocoapods, and I got an error in this file:

While, commenting it, allowed me to compile the app and launch WormHoly, and everything seems to work properly.

[ipavlidakis]

Thanks for checking @pmusolino. I just updated podspec to ignore the file. do you mind trying one more time?

[pmusolino]

The issue still persists @ipavlidakis, it seems the file has not been excluded, I'm still able to see it.

[ipavlidakis]

Interesting, maybe the pattern was wrong. I simplified it to be just the folder. Hope it works now

[pmusolino]

@ipavlidakis Now it works like a charm. I also tried to run the demo, and it works well! I'll review the code ASAP, and we can merge it. 👏

[pmusolino]

@ipavlidakis I started testing it with SPM. It has been integrated correctly into a project, with no issues. But Wormholy cannot be presented: manual fire or shake doesn't work. Any idea?

[federicosacca]

Hi @pmusolino, the problem is that the class at line 7 in the file (1) is 0x0 (null), because the correct class seems to be _WormholySwift. Maybe there is an issue in the package.swift declaration. Even if you change the class from @Wormholy.Wormholy to @Wormholy._WormholySwift, you will have problem in Flow.storyboard instantation, file (2).

(1) https://github.com/pmusolino/Wormholy/blob/master/Sources/Objc/WormholyConstructor.m (2) https://github.com/pmusolino/Wormholy/blob/master/Sources/UI/Flow.storyboard

[ipavlidakis]

@pmusolino do you have some code i can look into?

[pmusolino]

@ipavlidakis no code I can share. In any case, it's a project with both CocoaPods and SPM. Do you have the time to check what @federicosacca mentioned above?

[pmusolino]

@ipavlidakis do you have any news on this?

[parmar-mehul]

Hello Team, Can you please merge & release latest changes? @ipavlidakis

We are waiting for this changes to be merge from your side.

[acamcor-seatcode]

Hi! We are waiting too. It would be cool to have it. Tx!