search

pmusolino / Wormholy

iOS network debugging, like a wizard 🧙‍♂️
MIT License
2.33k stars 187 forks source link

Updated project to current Swift 4 standards. #31

Closed michaelharrigan closed 6 years ago

michaelharrigan commented 6 years ago

I was trying to build with Wormholy, in iOS 12 with Xcode 10, as a pod, when I was getting a lot of errors having to do with changes to Swift.

So I forked it really quick and ran the automatic converter with Swift.

I was having issue trying to export this as a framework and manually adding it to my project to test the changes.

michaelharrigan commented 6 years ago

Update: I pointed my pod file at my forked repo, installed, and built with Swift 4. Everything is working as it should now.

pmusolino commented 6 years ago

Thanks @michaelharrigan !

I will analyze your pull request as soon as possible.

-Paolo

StateMachineJunkie commented 6 years ago

@pmusolino I really need for you to get on integrating this pull request. Apple is about to release iOS 12 and Xcode 10. When that happens, they are likely to stop accepting submissions from Xcode 9. I've converted the rest of my project over to the latest version of Swift and all I need is for your pod to be updated. Please help me out and analyze this pull request ASAP. Thanks.

pmusolino commented 6 years ago

I accepted this PR, that is pretty similar. https://github.com/pmusolino/Wormholy/pull/42