Wormholy not being presented in certain cases

pmusolino / Wormholy

iOS network debugging, like a wizard 🧙‍♂️

MIT License

2.32k stars 184 forks source link

Wormholy not being presented in certain cases #44

Closed dimitris-c closed 5 years ago

dimitris-c commented 5 years ago

Currently if a UIViewController has presented a modal, Wormholy is unable to get presented.

I made a PR #43 to fix this by recursively checking the presentedViewController

pmusolino commented 5 years ago

Hi, @dimitris-c thanks for your PR!

I don't understand why you do this. In every case that I tested, Wormholy is presented in the right way, also if the view controller how present Wormholy is presented as a modal.

What is your use case?

dimitris-c commented 5 years ago

In my case, I use the library as part of a Debug menu, not as a standalone. In my case I had two modally presented view controllers, and Wormholy couldn't be presented.

pmusolino commented 5 years ago

PR merged, thanks @dimitris-c