pnathan / generic-comparability

implementation of cdr-8
http://cdr.eurolisp.org/document/8/cleqcmp.html
16 stars 2 forks source link

Depend on the generic-comparability system in the test system #7

Closed PuercoPop closed 6 years ago

PuercoPop commented 6 years ago

In order to address http://report.quicklisp.org/2018-01-16/failure-report/generic-comparability.html#generic-comparability-test

See http://blog.quicklisp.org/2018/01/build-failures-with-asdf-331.html for further context

pnathan commented 6 years ago

Hey, thanks!

Harleqin commented 6 years ago

Just a comment: I believe that ASDF nowadays expects a naming convention for dependent systems in the same file: the test system should be named generic-comparability/test. ASDF will emit a style-warning otherwise, I think.

Independently of this, you might want to use :in-order-to to have the test-op of the main system be a call to the test system.

PuercoPop commented 6 years ago

@Harleqin i had forgotten, you are right. We need to rename the test system or move it to its own test file.