pnathan / pp-toml

Paul's Parser for Tom's Own Minimal Language
https://github.com/mojombo/toml
Other
19 stars 3 forks source link

Fails to build on CCL due to the \#From character #25

Closed avodonosov closed 2 years ago

avodonosov commented 2 years ago

Thus breaking dependent systems as well: https://github.com/fisxoj/coo/issues/26

avodonosov commented 2 years ago

May be better to invert the reader conditional at https://github.com/pnathan/pp-toml/blob/a62825be8fb1f27760585ae138c904c8029b34db/pp-toml.lisp#L102, so that only implementations known to work are included, instead of excluding the implementations known to not work.

pnathan commented 2 years ago

Hi @avodonosov - good to know. Thank you for the bug report.

I'll see about addressing this in the next 1-2 days.

avodonosov commented 2 years ago

@pnathan , the following pull request fixes the issue by programmatically determining whether the current lisp implementation supports the #\From character: https://github.com/pnathan/pp-toml/pull/26

pnathan commented 2 years ago

thanks for the PR. I apologize for the ridiculous delay, I have been pretty wrapped in my (golang) work.